-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permit sort_name as a url parameter on advanced search #14475
Conversation
(Standard links)
|
d61b5ee
to
6f4a251
Compare
6f4a251
to
d88e84c
Compare
* This virtual function is used to set the default values of various form elements. | ||
* | ||
* @return array|NULL | ||
* reference to the array of default values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to parent
A baby step towards a larger goal. Nice :) Reviewing it now |
d88e84c
to
8c9cadd
Compare
Yup thanks for fixing the test failure :) |
@monishdeb we also need to do basic conversions on a couple more forms - pledge is here #14431 & I think Case & Membership remain (I've been doing small PRs for the basic converstions just to get the right functions in play) |
@eileenmcnaughton I think such improvements will eventually help us to get the search by url params doable for all search forms right ? |
@monishdeb yes! |
@monishdeb you can see the PR that build on this - #14477 exposes sort_name but also some other fields that are already metadata-defined as url fields |
Am happy with this patch. Tested on my local and worked fine. Merging it now |
@monishdeb nice - I'll rebase that participant one then |
Overview
This lays the ground work for our metadata based approach to search forms in the contact form. Specifically it converts one field (sort_name) to be added by metadata and also to be supported via url (sort_name=x)
Before
Metadata based approach not extended to contact form
After
Approach extended - the one converted field is url-parseable
Technical Details
@monishdeb putting this up to show where I think we should be going on this
Comments