Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#561 Convert pledge search form to use metadata functions #14431

Merged
merged 1 commit into from
Jun 12, 2019
Merged

dev/core#561 Convert pledge search form to use metadata functions #14431

merged 1 commit into from
Jun 12, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

This doesn't change anything of itself but is a pre-requisite for

  • removing jcalendar instances
  • supporting params in the url
  • supporting appropriate wildcards on text fields (not seemingly relevant on this entity).

In addition it is a driver for cleaning up metadata for our eventual leap away from quickform.

In this case the change highlighted the need to define the html type on the converted field
(pledge_status_id

Before

Pledge search form works

After

Pledge search form works

Technical Details

Comments

@eileenmcnaughton
Convert pledge search form to use metadata functions
52ddd94 
This doesn't change anything of itself but is a pre-requisite for
- removing jcalendar instances
- supporting params in the url
- supporting appropriate wildcards on text fields (not seemingly relevant on this entity).

In addition it is a driver for cleaning up metadata for our eventual leap away from quickform.

In this case the change highlighted the need to define the html type on the converted field
(pledge_status_id
@civibot
Copy link

civibot bot commented Jun 5, 2019

(Standard links)

@civibot civibot bot added the master label Jun 5, 2019
@yashodha
Copy link
Contributor

yashodha commented Jun 5, 2019

@eileenmcnaughton

Do we have a related ticket for this since we will be having a lot of these - might be easy to keep track.

@eileenmcnaughton
Copy link
Contributor Author

@yashodha yeah probably should - we kinda officially dropped the ticket as a requirement for a PR when we moved to gitlab - but I feel like we are moving back towards requiring them as people get more familiar with gitlab - although we are still a bit rubbish at closing gitlabs once things are resolved...

@eileenmcnaughton eileenmcnaughton changed the title Convert pledge search form to use metadata functions dev/core#561 Convert pledge search form to use metadata functions Jun 6, 2019
@eileenmcnaughton
Copy link
Contributor Author

@yashodha I've updated it to reference the jcalendar gitlab. There are multiple things we want to do this consolidation for but that's kinda top of the list

@eileenmcnaughton eileenmcnaughton mentioned this pull request Jun 7, 2019
Merged
@yashodha
Copy link
Contributor

yashodha commented Jun 7, 2019

@eileenmcnaughton great, thanks!

@eileenmcnaughton
Copy link
Contributor Author

@yashodha is this good to merge?

@yashodha
Copy link
Contributor

@eileenmcnaughton looks good, shall I merge this?

@eileenmcnaughton
Copy link
Contributor Author

@yashodha yep - go ahead

@yashodha yashodha merged commit 783db6a into civicrm:master Jun 12, 2019
@yashodha
Copy link
Contributor

@eileenmcnaughton I am merging this.

@eileenmcnaughton eileenmcnaughton deleted the pledge_search branch June 12, 2019 08:59
@eileenmcnaughton
Copy link
Contributor Author

thanks @yashodha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @yashodha