Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] formatting & comment fixes - Regenerate DAO files #14304

Merged
merged 1 commit into from
May 23, 2019
Merged

[NFC] formatting & comment fixes - Regenerate DAO files #14304

merged 1 commit into from
May 23, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 23, 2019 •
edited
Loading

Overview

Regenerate DAO files to pick up comment block fix #14296

Before

Wrong type in comment blocks for bool etc

After

fixed

Technical Details

Comments

@civibot
Copy link

civibot bot commented May 23, 2019

(Standard links)

@civibot civibot bot added the master label May 23, 2019
@eileenmcnaughton eileenmcnaughton changed the title Regenerate DAO files [NFC] formatting & comment fixes - Regenerate DAO files May 23, 2019
@eileenmcnaughton
Copy link
Contributor Author

This didn't pass style but the warnings are not new - I'm going to merge despite them (any real fails will surface next PR run & this doesn't need to fix pre-existings)

@eileenmcnaughton eileenmcnaughton merged commit 265ce2a into civicrm:master May 23, 2019
@eileenmcnaughton eileenmcnaughton deleted the dao branch May 23, 2019 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw