Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] fix docblock types from boolean to bool #14296

Merged
merged 1 commit into from
May 23, 2019
Merged

[NFC] fix docblock types from boolean to bool #14296

merged 1 commit into from
May 23, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 22, 2019 •
edited
Loading

Overview

Fix on code comment blocks type declaration

Before

Declared as boolean

After

Declared as bool

Technical Details

This is the correct type name we should be using

Comments

See civicrm/coder#7

@eileenmcnaughton
[NFC] fix docblock types from boolean to bool
b67daa7 
This is the correct type name we should be using
@civibot
Copy link

civibot bot commented May 22, 2019

(Standard links)

@civibot civibot bot added the master label May 22, 2019
@eileenmcnaughton
Copy link
Contributor Author

@colemanw can you merge? - there are a couple that cleanup the DAO too

colemanw
colemanw reviewed May 23, 2019
View reviewed changes
CRM/Case/Form/Search.php
*/
protected $_limit = NULL;

/**
* Prefix for the controller
* @var sting
* @var string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@colemanw colemanw merged commit 1f94fbf into civicrm:master May 23, 2019
@eileenmcnaughton eileenmcnaughton deleted the bool branch May 23, 2019 00:12
@eileenmcnaughton eileenmcnaughton mentioned this pull request May 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colemanw colemanw colemanw left review comments

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw