(dev/core#622) User Dashboard doesn't show Edit Contact Information link

[yashodha]

Overview

Edit Contact Information is not loading on the dashboard.
The buggy logic leads to having links getting overwritten.

Before

Edit Contact Information link is missing.

After

Edit Contact Information link is showing.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

This looks good. @yashodha it could be made even more concise by using the += operator.

[jitendrapurohit]

Have already tested this PR. See details at #13352 (comment). +1 to get this merged after the above changes for += is done.

[mattwire]

Tested with updates suggested by @colemanw. Reviewed by @jitendrapurohit and re-tested by me. Merge on pass

[colemanw]

@yashodha could you do a git squash and force push so this PR is only 1 commit instead of 3?

[eileenmcnaughton]

I just removed the merge on pass because I went to merge & realised there was a pending request for @yashodha to squash the commits - but @yashodha you can re-add the label once you have squashed them