fix verbiage for Edit Contact Information title

[yashodha]

Overview

fix verbiage for Edit Contact Information title

Before

Edit Contact Information title is wrongly shown as Edit Relationship

After

title reads Edit Contact Information

Comments

Title is misleading and does not match with the name.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[yashodha]

@jitendrapurohit found another one.

[jitendrapurohit]

On my testing - I wasn't able to see the link Edit Contact Information loading on the dashboard. Eg https://dmaster.demo.civicrm.org/civicrm/user?reset=1 displays the link for Dashboard and disable action, but no link to edit the contact details.

On digging into it a little, I see the reason for the link not loading on the page is because the file UserDashboard.php uses array_merge() and adds a disable action link which resets the keys in self::$_links variable.

If I change the line to eg self::$_links = self::$_links + array(....) instead of the existing array_merge(), the link is shown and the this PR correctly modifies the title to Edit Contact Information.

@yashodha If the above make sense, can you modify and fix the link display in this PR itself?

[yashodha]

@jitendrapurohit
makes sense :) I would rather have that fix in a different PR so that we have one PR tackle one problem.
#13353 is filed for the same.

[seamuslee001]

I'm going to merge this PR based on @jitendrapurohit 's comment of "the this PR correctly modifies the title to Edit Contact Information." Agree with Yash lets split out the other issue into its own PR