Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

campaign cleanup for household summary #13281

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Conversation

yashodha
Copy link
Contributor

Overview

Centralize and cleanup code for campaigns in reports

Before

hh_report_before

After

hh_report_after

Comments

Inactive campaigns can be seen in report filter and results as well.

@civibot
Copy link

civibot bot commented Dec 14, 2018

(Standard links)

@civibot civibot bot added the master label Dec 14, 2018
@yashodha
Copy link
Contributor Author

@seamuslee001 this is in continuation of #13243

@seamuslee001
Copy link
Contributor

(CiviCRM Review Template WORD-1.2)

  • General standards
    • (r-explain) Pass
    • (r-user) Pass
    • (r-doc) Pass
    • (r-run) Pass tested the report on a dmaster confirmed filters work and non active campaigns are available and confirmed when campaign is selected as a column it outputs correctly
  • Developer standards

@seamuslee001 seamuslee001 merged commit 5e8ab2f into civicrm:master Dec 21, 2018
@yashodha
Copy link
Contributor Author

@seamuslee001 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants