Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

campaign cleanup #13243

Merged
merged 1 commit into from
Dec 7, 2018
Merged

campaign cleanup #13243

merged 1 commit into from
Dec 7, 2018

Conversation

yashodha
Copy link
Contributor

@yashodha yashodha commented Dec 7, 2018

Overview

Centralize and cleanup code for campaigns in reports

Before

summary_before

After

summary_after

Comments

Inactive campaigns can be seen in report filter and results as well.

@civibot civibot bot added the master label Dec 7, 2018
@civibot
Copy link

civibot bot commented Dec 7, 2018

(Standard links)

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001
Copy link
Contributor

(CiviCRM Review Template WORD-1.2)

  • General standards
    • (r-explain) Pass
    • (r-user) Pass no visual change for the user
    • (r-doc) Pass
    • (r-run) Pass i tested the contribution summary report with and without campaign column and with and without campaign as the grouping and also with a filter on campaign and without and confirmed they all worked as expected
  • Developer standards

Adding merge on pass

@seamuslee001
Copy link
Contributor

Merging as per the tag

@seamuslee001 seamuslee001 merged commit 326a4ed into civicrm:master Dec 7, 2018
@yashodha yashodha mentioned this pull request Dec 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashodha @seamuslee001