Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#217) PrevNext - Define and use fillWithSql()/fillWithArray() #12545

Merged
merged 3 commits into from
Jul 24, 2018

Conversation

totten
Copy link
Member

@totten totten commented Jul 24, 2018

Overview

Update the PrevNext interface to define methods fillWithSql() and fillWithArray(). Update all (F1) existing contact-search screens to use these methods.

This is a cherry-pick from #12377.

See also: dev/core#217

Before

CRM_Contact_Selector (advanced search, et al) and CRM_Campaign_Selector_Search (reserve respondents, etc) fill the PrevNext cache by directly inserting to the SQL table civicrm_prevnext_cache

After

CRM_Contact_Selector (advanced search, et al) and CRM_Campaign_Selector_Search (reserve respondents, etc) fill the PrevNext cache by calling either Civi::service('prevnext')->fillWithSql() or Civi::service('prevnext')->fillWithArray()

Comments

(F1) In keeping with the general scoping of the dev/core#217, this PR only revises code used by the search UI -- it doesn't touch dedupe. For dedupe, the main concern is that it should continue writing directly to SQL. Since we only touch search UI code, this PR should have no impact on dedupe.

@civibot
Copy link

civibot bot commented Jul 24, 2018

(Standard links)

@eileenmcnaughton
Copy link
Contributor

I read through this & it looks good to me - I'm gonna do some testing on exporting from custom searches once this is merged & also once #12535 is merged (since I'd rather be testing both at once as they both touch search + export).

@eileenmcnaughton eileenmcnaughton merged commit 6bd8d4f into civicrm:master Jul 24, 2018
@totten totten deleted the master-prevnext-fill branch July 25, 2018 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants