(dev/core#217) PrevNext - Define and use fillWithSql()/fillWithArray() #12545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update the
PrevNext
interface to define methodsfillWithSql()
andfillWithArray()
. Update all (F1
) existing contact-search screens to use these methods.This is a cherry-pick from #12377.
See also: dev/core#217
Before
CRM_Contact_Selector
(advanced search, et al) andCRM_Campaign_Selector_Search
(reserve respondents, etc) fill the PrevNext cache by directly inserting to the SQL tablecivicrm_prevnext_cache
After
CRM_Contact_Selector
(advanced search, et al) andCRM_Campaign_Selector_Search
(reserve respondents, etc) fill the PrevNext cache by calling eitherCivi::service('prevnext')->fillWithSql()
orCivi::service('prevnext')->fillWithArray()
Comments
(
F1
) In keeping with the general scoping of the dev/core#217, this PR only revises code used by the search UI -- it doesn't touch dedupe. For dedupe, the main concern is that it should continue writing directly to SQL. Since we only touch search UI code, this PR should have no impact on dedupe.