Export Add unit test + minor refactor covering specifiable payment output fields for participant export. #12535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
changed the title
eileenmcnaughton
force-pushed
the
export_participant_test
branch
from
c41bd1e to
096e72c
Compare
eileenmcnaughton
force-pushed
the
export_participant_test
branch
from
096e72c to
876a47f
Compare
The selected payments field variable is primarily used when exporting participants with contributions. This gets the definition of it out of the returnProperties definition and calculates it more sensibly.
eileenmcnaughton
force-pushed
the
export_participant_test
branch
from
876a47f to
c66a574
Compare
|
Reviewing this now |
|
@stesi561 is this still pending you testing in the UI? |
|
Yes sorry I ran out of time last night. Will have a run at it tonight/tomorrow. If that's okay? |
|
@stesi561 perfectly fine :-) i think Eileen was just trying to check where things were at |
|
@stesi561 much appreciated! |
|
@stesi561 if you get a chance to check this today it would be fantastic - I have a couple more PR that will need rebasing once this is merged |
jitendrapurohit
approved these changes
Jul 30, 2018
|
Merging as per review by @stesi561 and testing by @jitendrapurohit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Unit test covering currently specifiable fields for participant export + refactor out $selectedPaymentFields & paymentTableId variables
Before
No test. Parameter passed via multiple functions
After
Parameter calculated by processor class, significant additional tests
Technical Details
The $selectedPaymentFields & paymentTableId variables are set when payment fields ( like contribution status) are specified on participant export. This test + refactor makes that more sane.
The goal here is to have a sensible separation of concerns in the various processing actions
Comments