Add utils for finding nested array items #12187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very much more elegant! |
|
Accurate patch + UT. Happy with the patch. |
|
merging as per the tag |
vinuvarshith
added a commit
to vinuvarshith/civicrm-core
that referenced
this pull request
Jul 9, 2018
|
JFYI, we now have two versions of this functionality -- Not really keen to push through a cleanup/reconciliation in this context... maybe we can do something for 5.5... |
|
Aww, that's a shame we all missed that. I'll do a followup PR for cleanup... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Just adding a utility function
Before
no change
After
no change
Comments
This is a reviewers cut of #12183