Add utils for recursively finding a key in an array when the depth of… #12183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree re switch can't see anything easier also ping @totten Tim you may want to have a view here but i think this is ok to me |
… the key is unknown
|
test this please |
colemanw
reviewed
May 23, 2018
| * @return bool | ||
| * @throws \CRM_Core_Exception | ||
| */ | ||
| public static function recursiveGetValue($array, $path, $default = FALSE) { |
There was a problem hiding this comment.
Shouldn't the default be NULL?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Just adding a utility function
Before
no change
After
no change
Technical Details
@seamuslee001 as discussed this allows us to clean up some code places where this is handled badly. I can't think of a prettier way than a switch but I think containing it in functions makes it OK
Comments