Add rule for separation

[elgui02]

Issue CRM-21859
Form for adding activities doesn't validate field Activity Separation when is called from list of contacts

Overview

Resolve issue when create an activity from contact search and can make a separation this separation isn't required

Before

Open page "Find Contacts" and click "Search"
Select first 50 records
Click on "Actions" field and choose "Add activity" (Selected contacts are in With contacts field)
Choose Meeting, clear Date and Time fields
Click Save button
Effect: The form doesn't validate the field "Activity Separation" and activity is created. There should be a warning "Activity Separation is a required field"

After

Open page "Find Contacts" and click "Search"
Select first 50 rekords
Click on "Actions" field and choose "Add activity" (Selected contacts are in With contacts field)
Choose Meeting, clear Date and Time fields
Click Save button
Effect: The form validate the field "Activity Separation" and activity is created and show a warning "Activity Separation is a required field"

Technical Details

Just add a rule for make required a separation when this is created

---

• CRM-21859: Form for adding activities doesn't validate field Activity Separation when is called from list of contacts

[civicrm-builder]

Can one of the admins verify this patch?

[seamuslee001]

Jenkins ok to test

[eileenmcnaughton]

I just spotted a risk here - the separation field is not always added to the form - so making it always required would potentially make a non-existent field required.

    $separationIsPossible = $this->supportsActivitySeparation;
    if ($actionIsAdd && $separationIsPossible) {
      $this->addRadio(
        'separation',
        ts('Activity Separation'),
        array(
          'separate' => ts('Create separate activities for each contact'),
          'combined' => ts('Create one activity with all contacts together'),
        )
      );
    }

Suggestion
the addRadio function takes 'required' as a parameter so add there

[elgui02]

If you view all if there is where rule is created

// Add the "Activity Separation" field
$actionIsAdd = $this->_action != CRM_Core_Action::UPDATE;
$separationIsPossible = $this->supportsActivitySeparation;
if ($actionIsAdd && $separationIsPossible) {
$this->addRadio(
'separation',
ts('Activity Separation'),
array(
'separate' => ts('Create separate activities for each contact'),
'combined' => ts('Create one activity with all contacts together'),
)
);
$this->addRule('separation', ts('Activity separation is a required field'), 'required');
}

[eileenmcnaughton]

AH ok - what does adding a required rule add compared to passing the param required? (I think the latter is more common)

[eileenmcnaughton]

@yashodha this seems to tie in with a ticket you logged so perhaps you could review it?

[eileenmcnaughton]

Cross referencing with #12223

[eileenmcnaughton]

I still think this should be passin $isRequired not addin a rule

$this->addRadio(
'separation',
ts('Activity Separation'),
array(
'separate' => ts('Create separate activities for each contact'),
'combined' => ts('Create one activity with all contacts together'),
),
NULL,
TRUE
);

calling

  public function &addRadio($name, $title, $values, $attributes = array(), $separator = NULL, $required = FALSE) {

[eileenmcnaughton]

I'm gonna close for now & you can re-open if you address - I think maybe you've moved on as no reply to comment in April