Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21677 reduce unnecessary joins in mailing reports #11876

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

yashodha
Copy link
Contributor

@yashodha yashodha commented Mar 26, 2018

Overview

Partial of #11814 which is a reviewers cut of #11550
Reduce unnecessary joins in mailing reports :

Mailing/Bounce
Mailing/Clicks
Mailing/Detail
Mailing/Opened

Before

unnecessary joins to phone table in mailing reports

After

join only when needed, code standardised

Comments

@eileenmcnaughton : want to merge this?


@eileenmcnaughton
Copy link
Contributor

I tested these 4 reports & noted a) that the report ran with & without the phone field present & b) that the phone table was / wasn't present in the query accordingly.

I note the email table / field could do with the same treatment on these reports & these class vars could be removed:

  protected $_emailField = FALSE;

  protected $_phoneField = FALSE;

but that should not delay the merge - merging

@eileenmcnaughton eileenmcnaughton merged commit e0f9f06 into civicrm:master Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants