CRM-21677 - Remove (some) unnecessary query joins when rendering reports #11814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
report
branch
3 times, most recently
from
c0e941f to
503a751
Compare
|
@yashodha just thinking about this - it might make sense to do a first PR with just the new functions & a couple of reports & then do the others in chunks - just because the QA task needs to be manageable |
eileenmcnaughton
force-pushed
the
report
branch
from
503a751 to
fc7b711
Compare
This was referenced Mar 23, 2018
eileenmcnaughton
force-pushed
the
report
branch
from
fc7b711 to
c23045a
Compare
|
@eileenmcnaughton agreed, will QA and merge |
eileenmcnaughton
force-pushed
the
report
branch
3 times, most recently
from
a8fa004 to
6949650
Compare
CRM-21677 - fix DB error and more clean up CRM-21677 - generalised function minor fix CRM-21677 - keep the naming consistent style fix
eileenmcnaughton
force-pushed
the
report
branch
from
6949650 to
18f511e
Compare
|
@jitendrapurohit @yashodha this is finally small enough to be reviewable as one chunk :-) |
|
@eileenmcnaughton : this works fine, merging. Top Donor report is giving DB error, but that is not related and is happening before applying patch and should be addressed separately. |
|
Yay - done! Thanks @yashodha @jitendrapurohit - I think it's great to have this pattern be consistent as we all know it will be the starting point for future copy & paste :-) |
eileenmcnaughton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Reviewers cut of #11550 - reduce unnecessary joins to address tables in reports
Before
unnecessary joins to phone, email and address tables
After
join only when needed, code standardised
Technical Details
This also aligns the approach with that used in the extended report extension - there might be some notices as I have updated the extension where the signature differs from core but will need to drop a new release & people will need to be on it.
Comments
@yashodha - I excluded this line https://github.com/civicrm/civicrm-core/pull/11550/files#diff-c2f466cf0d5fef7048b1ec82ec5aaaceL44 because I think it may be contentious (although I think I probably agree with the change personally)
Also, I decided to keep + deprecate the previous function names - we can remove them in a few point versions