CRM-20972 Handle new type of exception in PHP7.1 when too few argumen… #11515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts are passed in function
|
Jenkins re test this please |
1 similar comment
|
Jenkins re test this please |
|
jenkins, test this please |
2 similar comments
|
jenkins, test this please |
|
jenkins, test this please |
|
makes sense, only affects tests, doesn't reduce test coverage, jenkins pretty lacklustre, merge on pass |
|
just realised this is 4.6 - why aren't we getting these labels automatically so I can ignore 4.6 ones :-( |
|
Merging #11515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ts are passed in function
Overview
This handles a new Exception that is added in php7.1 which adds an exception when not enough params are passed in.
Before
if you run the test on php7.1 error is shown
After
No Error and tests pass
ping @jackrabbithanna again this is a PHP7.1 specific issue but it only affects tests and its a direct port of #10772