CRM-20972 Attempt to handle new type of Exception thrown in php7.1 wh… #10772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en function call has too few variables
|
@totten this passed by php7.1 set up and Jenkins has given it the nod. @eileenmcnaughton any thoughts on this? |
seamuslee001
changed the title
|
Interesting, and kinda cool. Since it's in the test suite jenkins is the ultimate arbiter of this patch. However, I think the main benefit of adding it is to show people what can be done (& perhaps later they will in their own extensions) so it probably at least needs to be flagged as a php 7.1 thing (ie. with code comments) |
|
oh I see - it is required for the tests - still think it would be nice to note it as 7.1 support |
|
@eileenmcnaughton how would you see that it should be noted as php7.1 support? |
|
@eileenmcnaughton I have added a code comment in each function now about the new Exception |
|
Fantastic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…en function call has too few variables