Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-19941 CRM-20943 Fix issue in PHP7.1 using is non object mode in … #10724

Merged
merged 1 commit into from
Jul 23, 2017
Merged

CRM-19941 CRM-20943 Fix issue in PHP7.1 using is non object mode in … #10724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CRM/Utils/PagerAToZ.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public static function createLinks(&$query, $sortByCharacter, $isDAO) {
$qfKey = CRM_Utils_Array::value('qfKey', $query->_formValues);
}
if (empty($qfKey)) {
$qfKey = CRM_Utils_Request::retrieve('qfKey', 'String', $this, FALSE, NULL, $_REQUEST);
$qfKey = CRM_Utils_Request::retrieve('qfKey', 'String', NULL, FALSE, NULL, $_REQUEST);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eileenmcnaughton @seamuslee001 this has caused a regression in my local. On visiting 'Manage Event' page it throws:

[24-Jul-2017 18:09:38 Asia/Aden] PHP Fatal error:  Cannot pass parameter 3 by reference in /Users/monish/src/civicrm/CRM/Utils/PagerAToZ.php on line 154

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eileenmcnaughton @seamuslee001 I just tested it and got the same error.

  $empty = NULL;
  $qfKey = CRM_Utils_Request::retrieve('qfKey', 'String', $empty, FALSE, NULL, $_REQUEST);

seems to work, as we are working with a variable and not a constant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spalmstr i picked up on your fix through #10748 which monish has now merged, Thanks for the pointer

}

$aToZBar = array();
Expand Down