CRM-19941 CRM-20943 Fix issue in PHP7.1 using is non object mode in … #10724
Conversation
|
@totten @eileenmcnaughton Tim and Eileen does this make sense to you two? |
|
No it terrifies me - not your patch - but that whole way retrieve sets variables on the form for reasons I don't understand but which may or may not relate to cross-tab submission |
|
ah well in this case we aren't in object mode and php7.1 throws up fatal error by us using $this (which doesn't seem to be initilised anyway) and its also a static function. |
|
that seems like a compelling case then! |
| @@ -151,7 +151,7 @@ public static function createLinks(&$query, $sortByCharacter, $isDAO) { | |||
| $qfKey = CRM_Utils_Array::value('qfKey', $query->_formValues); | |||
| } | |||
| if (empty($qfKey)) { | |||
| $qfKey = CRM_Utils_Request::retrieve('qfKey', 'String', $this, FALSE, NULL, $_REQUEST); | |||
| $qfKey = CRM_Utils_Request::retrieve('qfKey', 'String', NULL, FALSE, NULL, $_REQUEST); | |||
There was a problem hiding this comment.
@eileenmcnaughton @seamuslee001 this has caused a regression in my local. On visiting 'Manage Event' page it throws:
[24-Jul-2017 18:09:38 Asia/Aden] PHP Fatal error: Cannot pass parameter 3 by reference in /Users/monish/src/civicrm/CRM/Utils/PagerAToZ.php on line 154
There was a problem hiding this comment.
@eileenmcnaughton @seamuslee001 I just tested it and got the same error.
$empty = NULL;
$qfKey = CRM_Utils_Request::retrieve('qfKey', 'String', $empty, FALSE, NULL, $_REQUEST);
seems to work, as we are working with a variable and not a constant.
…AtoZ Pager
@spalmstr Stephen can you test this out, I think NULL makes the most amount of sense here rather than some uninitilised variable.