Change the format of the version tracking file #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonnnj
added
breaking change
mcdonnnj
force-pushed
the
improvement/change_version_file_format
branch
from
cf59ea7 to
13c5ef6
Compare
jsf9k
approved these changes
Oct 10, 2024
mcdonnnj
added
the
kraken 🐙
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
…format Change the format of the version tracking file
There is no reason to have any information but the version in the version tracking file for Packer template projects. The current format is simply an artifact of mirroring things over from the cisagov/skeleton-python-library project.
jsf9k
force-pushed
the
improvement/change_version_file_format
branch
from
13c5ef6 to
4934005
Compare
The src directory no longer exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request removes the Python trappings from the version tracking file (
src/version.txt). The version tracking file is changed to be a flat text file storing the version.💭 Motivation and context
When writing #377 I found myself questioning why the version was stored as it currently is and decided it should be changed.
🧪 Testing
Automated tests pass. I confirmed that the
bump_version.shscript worked as expected.✅ Pre-approval checklist