Change the format of the version tracking file #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonnnj
added
breaking change
jsf9k
approved these changes
Dec 6, 2024
dav3r
approved these changes
Dec 6, 2024
There is no reason to have any information but the version in the version tracking file for Docker image projects. The current format is simply an artifact of mirroring things over from the cisagov/skeleton-python-library project.
We were previously getting the version in three different tests. It makes more sense to turn getting the project version into a fixture and to use that fixture anywhere the project version is needed.
mcdonnnj
force-pushed
the
improvement/change_version_file_format
branch
from
4867f97 to
414efb4
Compare
mcdonnnj
added
the
test
jsf9k
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request removes the Python trappings from the version tracking file (
src/version.txt). The version tracking file is changed to be a flat text file storing the version. The test configuration is also updated to pull the project version in a fixture instead of in any test using it.💭 Motivation and context
This mirrors cisagov/skeleton-packer#379 as it has the same rationale. The test configuration change is to DRY out repeated logic.
🧪 Testing
Automated tests pass. I confirmed that the
bump-versionscript worked as expected.✅ Pre-approval checklist