Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version of the second bandit hook #188

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Nov 9, 2022

🗣 Description

This pull request updates the bandit (everything else) hook to use the latest version of bandit.

💭 Motivation and context

This hook was not kept in sync with updates to the bandit (tests tree) hook and is using an older version of bandit.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added the bug This issue or pull request addresses broken functionality label Nov 9, 2022
@mcdonnnj mcdonnnj self-assigned this Nov 9, 2022
@mcdonnnj mcdonnnj requested a review from dav3r as a code owner November 9, 2022 19:50
@mcdonnnj mcdonnnj requested review from felddy and jsf9k as code owners November 9, 2022 19:50
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@mcdonnnj mcdonnnj requested review from jsf9k and dav3r November 9, 2022 21:19
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

mcdonnnj and others added 3 commits November 14, 2022 12:30
The `bandit (everything else)` hook was not updated in sync with the
`bandit (tests tree)` hook and is using an older version of bandit.
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Update the other bandit hook's explanatory comment so the language is
consistent.
@mcdonnnj mcdonnnj force-pushed the bug/update_bandit_in_pre-commit_configuration branch from a749552 to 743e691 Compare November 14, 2022 17:30
@mcdonnnj mcdonnnj merged commit c8d7176 into develop Nov 14, 2022
@mcdonnnj mcdonnnj deleted the bug/update_bandit_in_pre-commit_configuration branch November 14, 2022 17:43
cisagovbot pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
Development

Successfully merging this pull request may close these issues.

3 participants