Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version of the second bandit hook #138

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Nov 21, 2022

🗣 Description

This pull request updates the bandit (everything else) hook to use the latest version of bandit. It also includes some cleanup for the explanatory comments for both bandit hooks.

💭 Motivation and context

This hook was not kept in sync with updates to the bandit (tests tree) hook and is using an older version of bandit. The comments make this configuration consistent with cisagov/skeleton-packer#188 and cisagov/skeleton-python-library#111.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added the bug This issue or pull request addresses broken functionality label Nov 21, 2022
@mcdonnnj mcdonnnj self-assigned this Nov 21, 2022
@mcdonnnj mcdonnnj requested a review from jsf9k as a code owner November 21, 2022 21:00
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the checkbox about adding tests in the PR description.

@mcdonnnj
Copy link
Member Author

Please remove the checkbox about adding tests in the PR description.

Tests have been added and/or modified to cover the changes in this PR.

This PR modifies the pre-commit configuration which I would consider part of the testing for this repository. Are we considering linting to be separate/different from testing in this regard? I've always taken "testing" to mean any element of our validation mechanisms.

@jsf9k
Copy link
Member

jsf9k commented Nov 21, 2022

This PR modifies the pre-commit configuration which I would consider part of the testing for this repository. Are we considering linting to be separate/different from testing in this regard? I've always taken "testing" to mean any element of our validation mechanisms.

Yes, but you're not adding tests that "cover the changes in this PR". That's what I think that checkbox is for.

If you disagree just leave it, and you can try to convince me later. I don't want to hold up the train for what is a flea-sized point.

@jsf9k
Copy link
Member

jsf9k commented Nov 21, 2022

Feel free to merge this without a second review, since @dav3r is out of the office right now.

mcdonnnj and others added 2 commits November 21, 2022 17:35
The `bandit (everything else)` hook was not updated in sync with the
`bandit (tests tree)` hook and is using an older version of bandit.
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
@mcdonnnj mcdonnnj force-pushed the bug/update_bandit_in_pre-commit_configuration branch from a89bf40 to 0ad31cc Compare November 21, 2022 22:35
@mcdonnnj mcdonnnj merged commit 649ad63 into develop Nov 21, 2022
@mcdonnnj mcdonnnj deleted the bug/update_bandit_in_pre-commit_configuration branch November 21, 2022 22:45
cisagovbot pushed a commit that referenced this pull request Sep 13, 2023
Add go packages for pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
Development

Successfully merging this pull request may close these issues.

2 participants