-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the version of the second bandit
hook
#138
Update the version of the second bandit
hook
#138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the checkbox about adding tests in the PR description.
This PR modifies the |
Yes, but you're not adding tests that "cover the changes in this PR". That's what I think that checkbox is for. If you disagree just leave it, and you can try to convince me later. I don't want to hold up the train for what is a flea-sized point. |
Feel free to merge this without a second review, since @dav3r is out of the office right now. |
The `bandit (everything else)` hook was not updated in sync with the `bandit (tests tree)` hook and is using an older version of bandit.
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
a89bf40
to
0ad31cc
Compare
Add go packages for pre-commit
🗣 Description
This pull request updates the
bandit (everything else)
hook to use the latest version of bandit. It also includes some cleanup for the explanatory comments for both bandit hooks.💭 Motivation and context
This hook was not kept in sync with updates to the
bandit (tests tree)
hook and is using an older version of bandit. The comments make this configuration consistent with cisagov/skeleton-packer#188 and cisagov/skeleton-python-library#111.🧪 Testing
Automated tests pass.
✅ Pre-approval checklist