Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Dockerfile changes from review #140

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request restores changes made during the review of #135.

💭 Motivation and context

When I was updating #135 for merge I managed to clobber these changes like a fool.
image

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added bug This issue or pull request addresses broken functionality kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Nov 22, 2022
@mcdonnnj mcdonnnj self-assigned this Nov 22, 2022
@mcdonnnj mcdonnnj requested a review from dav3r as a code owner November 22, 2022 15:46
I accidentally clobbered these changes when I was updating
#135 for merge. This restores the changes made
during review as well as fixing a missed reference to the CISA_USER
argument.

Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
@mcdonnnj mcdonnnj force-pushed the bug/fix_clobbered_dockerfile branch from 87fa1c0 to 8c73bf4 Compare November 22, 2022 15:50
@mcdonnnj mcdonnnj merged commit 8de42e4 into develop Nov 22, 2022
@mcdonnnj mcdonnnj deleted the bug/fix_clobbered_dockerfile branch November 22, 2022 16:23
cisagovbot pushed a commit that referenced this pull request Sep 13, 2023
…nfiguration

Update the Dependabot configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Development

Successfully merging this pull request may close these issues.

2 participants