Improve Dockerfile #135
Merged
Improve Dockerfile #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
the
improvement
jsf9k
force-pushed
the
improvement/dockerfile
branch
from
0afd230 to
98d58be
Compare
jsf9k
added
the
blocked
mcdonnnj
requested changes
Nov 9, 2022
mcdonnnj
reviewed
Nov 9, 2022
dav3r
approved these changes
Nov 14, 2022
mcdonnnj
approved these changes
Nov 14, 2022
Also add a section to update pip and setuptools via pip.
mcdonnnj
force-pushed
the
improvement/dockerfile
branch
from
90b1c72 to
2a72bf6
Compare
mcdonnnj
added a commit
that referenced
this pull request
Nov 22, 2022
I accidentally clobbered these changes when I was updating #135 for merge. This restores the changes made during review as well as fixing a missed reference to the CISA_USER argument. Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
6 tasks
mcdonnnj
added a commit
that referenced
this pull request
Nov 22, 2022
I accidentally clobbered these changes when I was updating #135 for merge. This restores the changes made during review as well as fixing a missed reference to the CISA_USER argument. Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
Sallenmoore
pushed a commit
to Sallenmoore/foundryvtt-docker
that referenced
this pull request
Jun 18, 2023
I accidentally clobbered these changes when I was updating cisagov/skeleton-docker#135 for merge. This restores the changes made during review as well as fixing a missed reference to the CISA_USER argument. Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request makes several small improvements to the repo's
Dockerfile.💭 Motivation and context
I have been using these improvements in descendants of cisagov/skeleton-docker as I skeletonize them, so it makes sense to go ahead and push the changes upstream.
🧪 Testing
All automated tests pass.
✅ Pre-approval checklist