Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate CI system and Docker Hub organization #12

Merged
merged 22 commits into from
Nov 14, 2019
Merged

Migrate CI system and Docker Hub organization #12

merged 22 commits into from
Nov 14, 2019

Conversation

felddy
Copy link
Member

@felddy felddy commented Nov 14, 2019

Description

This PR migrates the project from TravisCI to GitHub Actions. It also changes the Docker Hub organization from dhsncats to cisagov.

Motivation and Context

How Has This Been Tested?

Lint, build, test, and release actions have been executed and verified.

Screenshots (if appropriate):

None

Screenshots (if inappropriate):

giphy
Mr. Rogers

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

dav3r and others added 22 commits October 18, 2019 10:10
@dav3r
Add updates from running pre-commit autoupdate
78a230d
@dav3r
Merge pull request #18 from cisagov/improvement/updates_from_precommi…
b189690 
…t_autoupdate

Add updates from running pre-commit autoupdate
@felddy
Replace Travis-CI with GitHub actions.
05a136b
@felddy
Fix action shield link
02fb008
@felddy
Disable ansible-lint until they fix their setup.py
b31ad85 
See: ansible/ansible-lint#590
@felddy
Remove extra line.
b11e39a
@felddy
Merge pull request #20 from cisagov/improvement/actions
12b91c4 
Replace Travis-CI with GitHub actions
@mcdonnnj
Re-enabled ansible-lint and ran pre-commit autoupgrade.
3c78dd9
@mcdonnnj
Merge pull request #21 from cisagov/pre-commit_autoupdate_2019-11-02
7dfd8bf 
Re-enable ansible-lint and autoupgrade.
@felddy
Add GitHub action caching of pre-commit hooks and pip packages.
5d5567d
@felddy
Merge branch 'develop' into improvement/action_cache
c26ea01
@felddy
Remove search for previous pre-commit caches.
99c6115 
These seem to be very large caches.  Restoring an old one and updating 
it results in a cache larger than the maximum allowed cache size: 200MB. 
 
"Cache size of 254757924 bytes is over the 200MB limit, not saving 
cache."
So if the config changes it is best to just take the cache-miss and 
start from scratch.
@felddy
Merge pull request #22 from cisagov/improvement/action_cache
10bbfdf 
Add GitHub action caching of pre-commit hooks and pip packages.
@felddy
Merge branch 'develop' of github.com:cisagov/skeleton-generic into de…
0bea704 
…velop
@felddy
Add new workflow: lint, test, and build artifact.
398e7f5
@felddy
Add release workflow based on Travis.
6bdab7d
@felddy
Remove Travis configuration.
5686bbe
@felddy
Create a version lookup step with output.
1a174ba
@felddy
Reorder jobs and pass image artifacts.
57dfd9f
@felddy
Simplify artifact naming.
78348f6
@felddy
Change environment variable name to be CI agnostic.
9251add
@felddy
Move images from dhsncats to cisagov docker hub org.
7ed5c76
@felddy felddy self-assigned this Nov 14, 2019
jsf9k
jsf9k approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, skip!

mcdonnnj
mcdonnnj approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm digging it 🚀

@felddy felddy merged commit 89cea1b into develop Nov 14, 2019
@felddy felddy deleted the improvement/actions branch November 14, 2019 18:57
@felddy felddy restored the improvement/actions branch November 14, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@jsf9k jsf9k jsf9k approved these changes

@KyleEvers KyleEvers Awaiting requested review from KyleEvers

@dav3r dav3r Awaiting requested review from dav3r dav3r is a code owner

Assignees

@felddy felddy

Labels
None yet
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to GitHub Actions
4 participants
@felddy @jsf9k @mcdonnnj @dav3r