Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull in upstream changes from cisagov/skeleton-generic #21

Merged
merged 3 commits into from
Apr 27, 2020
Merged

Pull in upstream changes from cisagov/skeleton-generic #21

merged 3 commits into from
Apr 27, 2020

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Apr 27, 2020

🗣 Description

This pull request pulls in upstream changes from cisagov/skeleton-generic.

💭 Motivation and Context

We need the change in cisagov/skeleton-generic that added @hillaryj as a code owner to trickle down.

🧪 Testing

All pre-commit hooks pass.

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jsf9k jsf9k requested review from dav3r, felddy, mcdonnnj and a team as code owners April 27, 2020 13:50
@jsf9k jsf9k requested a review from hillaryj April 27, 2020 13:51
@jsf9k jsf9k self-assigned this Apr 27, 2020
dav3r
dav3r approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦘

mcdonnnj
mcdonnnj approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎

@jsf9k jsf9k merged commit c9c38b0 into develop Apr 27, 2020
@jsf9k jsf9k deleted the improvement/upstream-changes branch April 27, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@hillaryj hillaryj Awaiting requested review from hillaryj

Assignees

@jsf9k jsf9k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @dav3r @mcdonnnj @hillaryj