Support "urgent tickets" queries #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code would throw an error.
"urgent" tickets are defined as meeting at least one of the following criteria: * KEV (Known Exploited Vulnerability) = true * Critical (severity = 4) * High (severity = 3)
dav3r
added
the
improvement
jsf9k
approved these changes
Apr 11, 2022
This was referenced Apr 11, 2022
|
@dav3r Would you manually run |
mcdonnnj
approved these changes
Apr 13, 2022
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR updates some queries that are used to create CSVs containing open or recently-closed tickets. It allows for a new faux severity called "urgent", which includes tickets that meet at least one of the following criteria:
In addition, I also added the KEV flag and ticket severity to the CSV output.
During my testing, I encountered a pre-existing bug, so I fixed that in 0b0336e.
💭 Motivation and context
This PR resolves cisagov/cyhy-system#48.
This PR covers part of the work requested in cisagov/cyhy-system#34.
🧪 Testing
I used this updated code to generate new "urgent tickets" CSVs (for both open and closed tickets) using my test data and verified that the output looked as expected.
I also tested my code by generating the existing CSVs (for critical-severity tickets and high-severity tickets) and the urgent tickets CSVs, using Production data and verified that the output looked as expected. There were no unexpected changes to the existing CSVs (which will continue to be used by the CyHy Dashboard).
To generate my testing CSVs, I wrote some test code similar to this.
✅ Pre-approval checklist
to reflect the changes in this PR.