Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send "urgent tickets" CSVs #92

Merged
merged 10 commits into from
Apr 28, 2022
Merged

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented Apr 12, 2022

🗣 Description

This PR modifies cyhy-mailer to attach the new "urgent tickets" CSVs (instead of the previous "critical" and "high" CSVs) when emailing the Cyber Exposure (CybEx) scorecard.

While I was here, I updated the pre-commit config and a couple of related changes (see commits 8fef4c7, fc34ca5, d396e61).

💭 Motivation and context

🧪 Testing

I tested this change by temporarily modifying the default email/BCC addresses to point to my email address, then ran this command:

$ AWS_DEFAULT_REGION=us-east-1 AWS_PROFILE=my_email_sending_profile cyhy-mailer cybex \
--cybex-scorecard-dir=test_scorecards/ --db-creds=./secrets/db-creds.yml --summary-to=me@myemail.gov

After I ran that, I confirmed that I received an email containing the new "urgent tickets" CSVs (that I had previously generated while testing cisagov/cyhy-reports#70).

I also verified that there were no failures when I ran pytest.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

✅ Post-merge checklist

  • Add a tag (but don't create a release).

@dav3r dav3r added blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add new or improve existing functionality labels Apr 12, 2022
@dav3r dav3r requested review from felddy, jsf9k, mcdonnnj and a team as code owners April 12, 2022 14:25
@dav3r dav3r self-assigned this Apr 12, 2022
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything functionality wise looks good. On the back of my comments please make sure to run a pre-commit run --all-files to make sure the updated pre-commit configuration is applied to this repository since there is no GitHub Actions testing.

@dav3r dav3r requested a review from mcdonnnj April 13, 2022 14:45
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔

Copy link
Member

@felddy felddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"So Urgent!" 🎷

@dav3r dav3r merged commit 5c147e9 into develop Apr 28, 2022
@dav3r dav3r deleted the improvement/send-urgent-tickets-csvs branch April 28, 2022 19:23
@dav3r dav3r removed the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add new or improve existing functionality
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update cyhy-mailer to only send 2 new CSVs based on urgency
4 participants