-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send "urgent tickets" CSVs #92
Conversation
Also, add modern bandit and markdownlint configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything functionality wise looks good. On the back of my comments please make sure to run a pre-commit run --all-files
to make sure the updated pre-commit
configuration is applied to this repository since there is no GitHub Actions testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"So Urgent!" 🎷
🗣 Description
This PR modifies
cyhy-mailer
to attach the new "urgent tickets" CSVs (instead of the previous "critical" and "high" CSVs) when emailing the Cyber Exposure (CybEx) scorecard.While I was here, I updated the pre-commit config and a couple of related changes (see commits 8fef4c7, fc34ca5, d396e61).
💭 Motivation and context
🧪 Testing
I tested this change by temporarily modifying the default email/BCC addresses to point to my email address, then ran this command:
After I ran that, I confirmed that I received an email containing the new "urgent tickets" CSVs (that I had previously generated while testing cisagov/cyhy-reports#70).
I also verified that there were no failures when I ran
pytest
.✅ Pre-approval checklist
✅ Pre-merge checklist
epic/bod-22-01
branch (which includes Generate "urgent tickets" CSVs cyhy-reports#70) has been deployed or will be deployed before this PR.✅ Post-merge checklist