Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Heading Markup for "Clear All Filters" and "By Status" #3164

Closed
5 of 11 tasks
SamiyahKey opened this issue Dec 2, 2024 · 1 comment · Fixed by #3489
Closed
5 of 11 tasks

Correct Heading Markup for "Clear All Filters" and "By Status" #3164

SamiyahKey opened this issue Dec 2, 2024 · 1 comment · Fixed by #3489
Assignees
@CocoByte
Labels
accessibility pertains to Section 508 compliance or other accessibility needs 👥 Pod:Accessibility Compliance Describes work needed for get.gov and manage.get.gov to be Section 508 Compliant carryover Carryover from a previous sprint compliance indicates that the issue is required to satisfy a necessary compliance req dev issue is for the dev team story User stories

Comments

@SamiyahKey
Copy link

SamiyahKey commented Dec 2, 2024 •
edited by zandercymatics
Loading

Story

As a screen reader user,
I need elements like "Clear All Filters" and "By Status" to be marked up according to their actual roles,
So that I can understand the true purpose and structure of the page without confusion.

URL: Domain Request
https://getgov-staging.app.cloud.gov/admin/registrar/domainrequest/

Acceptance Criteria

  • Correct Markup:
  • "Clear All Filters" and "By Status" must be marked up using appropriate elements that reflect their actual role.
  • For example, "Clear All Filters" should be a button or link if it is an actionable control.
  • "By Status" could be a or
    with appropriate ARIA attributes if it is purely descriptive.
  • Remove Heading Tags:
  • Ensure these elements are no longer marked as headings (e.g., < h1 >, < h2 >, etc.) unless they truly serve as headings defining sections of the page.
  • Accessibility Testing:
  • Use a screen reader to verify that these elements are no longer announced as headings.
  • Ensure that their roles and purposes are clear and align with their visual and programmatic presentation.
  • Visual Consistency:
  • Verify that changes to markup do not affect the visual presentation or functionality of these elements.

Additional Context

No response

Issue Links

No response
@SamiyahKey SamiyahKey added compliance indicates that the issue is required to satisfy a necessary compliance req dev issue is for the dev team skipped design Design artifact(s) will need to be updated story User stories labels Dec 2, 2024
@SamiyahKey SamiyahKey added the accessibility pertains to Section 508 compliance or other accessibility needs label Dec 2, 2024
@zandercymatics zandercymatics added 👥 Pod:Accessibility Compliance Describes work needed for get.gov and manage.get.gov to be Section 508 Compliant and removed 👥 Pod:Accessibility Compliance Describes work needed for get.gov and manage.get.gov to be Section 508 Compliant labels Jan 29, 2025
@CocoByte CocoByte moved this from 👶 New to 🔖 Planned in .gov Product Board Feb 5, 2025
@CocoByte CocoByte moved this from 🔖 Planned to 🏗 In progress in .gov Product Board Feb 6, 2025
@CocoByte CocoByte moved this from 🏗 In progress to 👀 In review in .gov Product Board Feb 10, 2025
@CocoByte CocoByte mentioned this issue Feb 10, 2025
Merged
32 tasks
@MzBowieFan77 MzBowieFan77 added the carryover Carryover from a previous sprint label Feb 19, 2025
zandercymatics added a commit that referenced this issue Feb 19, 2025
@zandercymatics
Merge pull request #3489 from cisagov/nl/3164-markup-correction-for-c…
669f882 
…lear-filters-and-status

#3164 - markup correction for clear filters and status - [Hotgov]
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in .gov Product Board Feb 19, 2025
@Katherine-MN Katherine-MN removed the skipped design Design artifact(s) will need to be updated label Mar 6, 2025
@Katherine-MN
Copy link
Contributor

Removed "skipped design" to reflect that an update to design documentation or libraries is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CocoByte CocoByte

Labels
accessibility pertains to Section 508 compliance or other accessibility needs 👥 Pod:Accessibility Compliance Describes work needed for get.gov and manage.get.gov to be Section 508 Compliant carryover Carryover from a previous sprint compliance indicates that the issue is required to satisfy a necessary compliance req dev issue is for the dev team story User stories
Projects
.gov Product Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3164 - markup correction for clear filters and status - [Hotgov] cisagov/manage.get.gov
5 participants
@CocoByte @Katherine-MN @zandercymatics @SamiyahKey @MzBowieFan77