Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3164 - markup correction for clear filters and status - [Hotgov] #3489

Merged

Conversation

CocoByte
Copy link
Contributor

@CocoByte CocoByte commented Feb 10, 2025

Ticket 3164

Resolves #3164

Changes

  • Stripped header markup from "Clear all filters" link and from "Status" filter header

Context for reviewers

The clear all filters link is a Django default and had to be overridden

Setup

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

  • Met the acceptance criteria, or will meet them in a subsequent PR
  • Created/modified automated tests
  • Update documentation in READMEs and/or onboarding guide

Ensured code standards are met (Original Developer)

  • If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
  • Interactions with external systems are wrapped in try/except
  • Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

  • Tag @dotgov-designers in this PR's Reviewers for design review. If code is not user-facing, delete design reviewer checklist
  • Verify new pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
  • Checked keyboard navigability
  • Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

  • Pulled this branch locally and tested it
  • Verified code meets all checks above. Address any checks that are not satisfied
  • Reviewed this code and left comments. Indicate if comments must be addressed before code is merged
  • Checked that all code is adequately covered by tests
  • Verify migrations are valid and do not conflict with existing migrations

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.

  • New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
  • Checked keyboard navigability
  • Meets all designs and user flows provided by design/product
  • Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
  • (Rarely needed) Tested as both an analyst and applicant user

As a designer reviewer, I have

Verified that the changes match the design intention

  • Checked that the design translated visually
  • Checked behavior. Comment any found issues or broken flows.
  • Checked different states (empty, one, some, error)
  • Checked for landmarks, page heading structure, and links

Validated user-facing changes as a designer

  • Checked keyboard navigability
  • Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
  • Tested with multiple browsers (check off which ones were used)
    • Chrome
    • Microsoft Edge
    • FireFox
    • Safari
  • (Rarely needed) Tested as both an analyst and applicant user

References

Screenshots

@CocoByte CocoByte requested a review from allly-b as a code owner February 10, 2025 18:03
Copy link

🥳 Successfully deployed to developer sandbox nl.

@CocoByte CocoByte changed the title [DRAFT] #3164 - markup correction for clear filters and status #3164 - markup correction for clear filters and status - [Hotgov] Feb 10, 2025
@zandercymatics zandercymatics self-assigned this Feb 11, 2025
Copy link

🥳 Successfully deployed to developer sandbox nl.

@zandercymatics
Copy link
Contributor

Just a fyi @CocoByte, I will say that @rachidatecs 's comments supersede mine on the change requests

Copy link

🥳 Successfully deployed to developer sandbox nl.

Copy link

🥳 Successfully deployed to developer sandbox nl.

@CocoByte CocoByte requested a review from rachidatecs February 17, 2025 21:31
Copy link

🥳 Successfully deployed to developer sandbox nl.

Copy link
Contributor

@zandercymatics zandercymatics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CocoByte CocoByte requested a review from SamiyahKey February 18, 2025 16:38
Copy link

🥳 Successfully deployed to developer sandbox nl.

@zandercymatics zandercymatics merged commit 669f882 into main Feb 19, 2025
10 checks passed
@zandercymatics zandercymatics deleted the nl/3164-markup-correction-for-clear-filters-and-status branch February 19, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct Heading Markup for "Clear All Filters" and "By Status"
4 participants