-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3164 - markup correction for clear filters and status - [Hotgov] #3489
#3164 - markup correction for clear filters and status - [Hotgov] #3489
Conversation
🥳 Successfully deployed to developer sandbox nl. |
src/registrar/templates/django/admin/multiple_choice_list_filter.html
Outdated
Show resolved
Hide resolved
src/registrar/templates/django/admin/multiple_choice_list_filter.html
Outdated
Show resolved
Hide resolved
🥳 Successfully deployed to developer sandbox nl. |
Just a fyi @CocoByte, I will say that @rachidatecs 's comments supersede mine on the change requests |
🥳 Successfully deployed to developer sandbox nl. |
🥳 Successfully deployed to developer sandbox nl. |
🥳 Successfully deployed to developer sandbox nl. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🥳 Successfully deployed to developer sandbox nl. |
Ticket 3164
Resolves #3164
Changes
Context for reviewers
The clear all filters link is a Django default and had to be overridden
Setup
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Validated user-facing changes as a developer
Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
References
Screenshots