crd: make followChildren optional #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkourt
added
the
release-note/misc
kkourt
force-pushed
the
pr/kkourt/crd-fix-followchidren
branch
from
34e09d6 to
0466e25
Compare
kkourt
force-pushed
the
pr/kkourt/crd-fix-followchidren
branch
from
0466e25 to
8ca1dc1
Compare
mtardy
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
55117f5 Introduced a new field (followChildren), but it was not marked as optional which is a breaking change.
Make the field optional and false by default.
fixes: 55117f5
Reported by @lambdanis #2720 (comment)