Skip to content

Commit

Permalink
crd: make followChildren optional
Browse files Browse the repository at this point in the history 
55117f5 Introduced a new field
(followChildren), but it was not marked as optional which is a breaking
change.

Make the field optional and false by default.

fixes: 55117f5

Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
  • Loading branch information
@kkourt
kkourt committed Aug 12, 2024
1 parent c638b45 commit 9dac153
Show file tree
Hide file tree
Showing 10 changed files with 30 additions and 26 deletions.
8 changes: 4 additions & 4 deletions install/kubernetes/tetragon/crds-yaml/cilium.io_tracingpolicies.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,7 @@ spec:
items:
properties:
followChildren:
default: false
description: In addition to binaries, match children
processes of specified binaries.
type: boolean
Expand All @@ -462,7 +463,6 @@ spec:
type: string
type: array
required:
- followChildren
- operator
- values
type: object
Expand Down Expand Up @@ -1054,6 +1054,7 @@ spec:
items:
properties:
followChildren:
default: false
description: In addition to binaries, match children
processes of specified binaries.
type: boolean
Expand All @@ -1071,7 +1072,6 @@ spec:
type: string
type: array
required:
- followChildren
- operator
- values
type: object
Expand Down Expand Up @@ -1694,6 +1694,7 @@ spec:
items:
properties:
followChildren:
default: false
description: In addition to binaries, match children
processes of specified binaries.
type: boolean
Expand All @@ -1711,7 +1712,6 @@ spec:
type: string
type: array
required:
- followChildren
- operator
- values
type: object
Expand Down Expand Up @@ -2271,6 +2271,7 @@ spec:
items:
properties:
followChildren:
default: false
description: In addition to binaries, match children
processes of specified binaries.
type: boolean
Expand All @@ -2288,7 +2289,6 @@ spec:
type: string
type: array
required:
- followChildren
- operator
- values
type: object
Expand Down
8 changes: 4 additions & 4 deletions install/kubernetes/tetragon/crds-yaml/cilium.io_tracingpoliciesnamespaced.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,7 @@ spec:
items:
properties:
followChildren:
default: false
description: In addition to binaries, match children
processes of specified binaries.
type: boolean
Expand All @@ -462,7 +463,6 @@ spec:
type: string
type: array
required:
- followChildren
- operator
- values
type: object
Expand Down Expand Up @@ -1054,6 +1054,7 @@ spec:
items:
properties:
followChildren:
default: false
description: In addition to binaries, match children
processes of specified binaries.
type: boolean
Expand All @@ -1071,7 +1072,6 @@ spec:
type: string
type: array
required:
- followChildren
- operator
- values
type: object
Expand Down Expand Up @@ -1694,6 +1694,7 @@ spec:
items:
properties:
followChildren:
default: false
description: In addition to binaries, match children
processes of specified binaries.
type: boolean
Expand All @@ -1711,7 +1712,6 @@ spec:
type: string
type: array
required:
- followChildren
- operator
- values
type: object
Expand Down Expand Up @@ -2271,6 +2271,7 @@ spec:
items:
properties:
followChildren:
default: false
description: In addition to binaries, match children
processes of specified binaries.
type: boolean
Expand All @@ -2288,7 +2289,6 @@ spec:
type: string
type: array
required:
- followChildren
- operator
- values
type: object
Expand Down
8 changes: 4 additions & 4 deletions pkg/k8s/apis/cilium.io/client/crds/v1alpha1/cilium.io_tracingpolicies.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,7 @@ spec:
items:
properties:
followChildren:
default: false
description: In addition to binaries, match children
processes of specified binaries.
type: boolean
Expand All @@ -462,7 +463,6 @@ spec:
type: string
type: array
required:
- followChildren
- operator
- values
type: object
Expand Down Expand Up @@ -1054,6 +1054,7 @@ spec:
items:
properties:
followChildren:
default: false
description: In addition to binaries, match children
processes of specified binaries.
type: boolean
Expand All @@ -1071,7 +1072,6 @@ spec:
type: string
type: array
required:
- followChildren
- operator
- values
type: object
Expand Down Expand Up @@ -1694,6 +1694,7 @@ spec:
items:
properties:
followChildren:
default: false
description: In addition to binaries, match children
processes of specified binaries.
type: boolean
Expand All @@ -1711,7 +1712,6 @@ spec:
type: string
type: array
required:
- followChildren
- operator
- values
type: object
Expand Down Expand Up @@ -2271,6 +2271,7 @@ spec:
items:
properties:
followChildren:
default: false
description: In addition to binaries, match children
processes of specified binaries.
type: boolean
Expand All @@ -2288,7 +2289,6 @@ spec:
type: string
type: array
required:
- followChildren
- operator
- values
type: object
Expand Down
8 changes: 4 additions & 4 deletions pkg/k8s/apis/cilium.io/client/crds/v1alpha1/cilium.io_tracingpoliciesnamespaced.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,7 @@ spec:
items:
properties:
followChildren:
default: false
description: In addition to binaries, match children
processes of specified binaries.
type: boolean
Expand All @@ -462,7 +463,6 @@ spec:
type: string
type: array
required:
- followChildren
- operator
- values
type: object
Expand Down Expand Up @@ -1054,6 +1054,7 @@ spec:
items:
properties:
followChildren:
default: false
description: In addition to binaries, match children
processes of specified binaries.
type: boolean
Expand All @@ -1071,7 +1072,6 @@ spec:
type: string
type: array
required:
- followChildren
- operator
- values
type: object
Expand Down Expand Up @@ -1694,6 +1694,7 @@ spec:
items:
properties:
followChildren:
default: false
description: In addition to binaries, match children
processes of specified binaries.
type: boolean
Expand All @@ -1711,7 +1712,6 @@ spec:
type: string
type: array
required:
- followChildren
- operator
- values
type: object
Expand Down Expand Up @@ -2271,6 +2271,7 @@ spec:
items:
properties:
followChildren:
default: false
description: In addition to binaries, match children
processes of specified binaries.
type: boolean
Expand All @@ -2288,7 +2289,6 @@ spec:
type: string
type: array
required:
- followChildren
- operator
- values
type: object
Expand Down
2 changes: 2 additions & 0 deletions pkg/k8s/apis/cilium.io/v1alpha1/types.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ type BinarySelector struct {
// Value to compare the argument against.
Values []string `json:"values"`
// In addition to binaries, match children processes of specified binaries.
// +kubebuilder:validation:Optional
// +kubebuilder:default=false
FollowChildren bool `json:"followChildren"`
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/k8s/apis/cilium.io/v1alpha1/version.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ package v1alpha1
// Used to determine if CRD needs to be updated in cluster
//
// Developers: Bump patch for each change in the CRD schema.
const CustomResourceDefinitionSchemaVersion = "1.2.2"
const CustomResourceDefinitionSchemaVersion = "1.2.3"
8 changes: 4 additions & 4 deletions ...ilium/tetragon/pkg/k8s/apis/cilium.io/client/crds/v1alpha1/cilium.io_tracingpolicies.yaml
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ...agon/pkg/k8s/apis/cilium.io/client/crds/v1alpha1/cilium.io_tracingpoliciesnamespaced.yaml
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 9dac153

Please sign in to comment.