Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Migrate max_seq_id in pickle if present #3777

Merged
merged 6 commits into from
Feb 13, 2025
Merged

[BUG] Migrate max_seq_id in pickle if present #3777

merged 6 commits into from
Feb 13, 2025

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Feb 12, 2025 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Make max_seq_id optional in PersistData
    • Purge log after backfill
    • Update test_cross_version_persist.py
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@Sicheng-Pan Sicheng-Pan mentioned this pull request Feb 12, 2025
Merged
1 task
@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Sicheng-Pan Graphite App
Copy link
Contributor Author

Sicheng-Pan commented Feb 12, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review February 12, 2025 19:47
@Sicheng-Pan Sicheng-Pan force-pushed the 02-12-_bug_migrate_max_seq_id_in_pickle_if_present branch from cda5006 to 9642396 Compare February 12, 2025 21:50
@Sicheng-Pan Graphite App
Copy link
Contributor Author

Sicheng-Pan commented Feb 13, 2025 •
edited
Loading

Merge activity

  • Feb 13, 2:37 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 13, 2:39 PM EST: Graphite rebased this pull request as part of a merge.
  • Feb 13, 2:40 PM EST: A user merged this pull request with Graphite.

@Sicheng-Pan Sicheng-Pan changed the base branch from 02-11-_tst_enable_legacy_tests to graphite-base/3777 February 13, 2025 19:37
@Sicheng-Pan Sicheng-Pan changed the base branch from graphite-base/3777 to main February 13, 2025 19:37
@Sicheng-Pan Sicheng-Pan force-pushed the 02-12-_bug_migrate_max_seq_id_in_pickle_if_present branch from 9360943 to d4d6642 Compare February 13, 2025 19:38
@Sicheng-Pan Sicheng-Pan merged commit 6afe046 into main Feb 13, 2025
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sicheng-Pan