Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TST] Enable legacy tests #3764

Merged
merged 12 commits into from
Feb 13, 2025
Merged

[TST] Enable legacy tests #3764

merged 12 commits into from
Feb 13, 2025

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Feb 11, 2025 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Enable some existing Python tests
      • test_cross_version_persist.py
      • test_log_purge.py
  • New functionality
    • N/A

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review February 11, 2025 21:06
@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Sicheng-Pan Graphite App
Copy link
Contributor Author

Sicheng-Pan commented Feb 11, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sicheng-Pan Sicheng-Pan force-pushed the 02-11-_tst_enable_legacy_tests branch from 500eb72 to cc4a212 Compare February 11, 2025 23:55
codetheweb
codetheweb reviewed Feb 12, 2025
View reviewed changes
chromadb/test/conftest.py
if "CHROMA_RUST_BINDINGS_TEST_ONLY" in os.environ:
yield from rust_system()
else:
yield from sqlite_persistent_fixture()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels a little bit weird but I think it makes sense
we should do the same thing for the sqlite_fixture once ephemeral mode is supported on Rust

chromadb/api/rust.py Outdated Show resolved Hide resolved
@Sicheng-Pan Sicheng-Pan force-pushed the 02-11-_tst_enable_legacy_tests branch 2 times, most recently from b2bcd8d to b33f7ce Compare February 12, 2025 06:16
@Sicheng-Pan Sicheng-Pan force-pushed the 02-11-_tst_enable_legacy_tests branch from 35b58b5 to b853147 Compare February 12, 2025 19:46
@Sicheng-Pan Sicheng-Pan mentioned this pull request Feb 12, 2025
Merged
1 task
@Sicheng-Pan Graphite App
Copy link
Contributor Author

Sicheng-Pan commented Feb 13, 2025 •
edited
Loading

Merge activity

  • Feb 13, 2:37 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 13, 2:37 PM EST: A user merged this pull request with Graphite.

@Sicheng-Pan Sicheng-Pan merged commit 13bf091 into main Feb 13, 2025
100 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codetheweb codetheweb codetheweb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sicheng-Pan @codetheweb