Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLN] Support numpy >=2.0 #2811

Merged
merged 1 commit into from
Sep 17, 2024
Merged

[CLN] Support numpy >=2.0 #2811

merged 1 commit into from
Sep 17, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Sep 17, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Supports numpy 2.0 now that onnxruntime supports it by removing our limit of <2.0
    • Change usage of float_ to float64. These are supported in both < and >= 2.0. However float_ is only supported by < 2.0. In < 2.0 the _ types are shorthand for the 64bit wide datatypes. I verified this. This makes the changes cleaner than [ENH] Support >= numpy 2.0 #2776.
Screenshot 2024-09-17 at 10 15 21 AM
  • New functionality
    • None

Test plan

How are these changes tested?
Existing tests

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB HammadB mentioned this pull request Sep 17, 2024
Closed
1 task
@codetheweb codetheweb mentioned this pull request Sep 17, 2024
Closed
@HammadB HammadB merged commit 9ab0196 into main Sep 17, 2024
70 checks passed
@HammadB HammadB mentioned this pull request Sep 17, 2024
Merged
1 task
HammadB added a commit that referenced this pull request Sep 17, 2024
@HammadB
[BUG] Fix CVP tests by forcing numpy reimport (#2814)
b77f73b 
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
	 - Fix CVP tests which broke in #2811 by reimporting numpy
 - New functionality
	 - None

## Test plan
*How are these changes tested?*
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codetheweb codetheweb codetheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HammadB @codetheweb