-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Support >= numpy 2.0 #2776
Conversation
Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikechroma and the rest of your teammates on Graphite |
Were you able to test this / confirm that onnxruntime released a supporting version to Pypi? |
this is still in wip. let me test it today |
b736380
to
bc99fdd
Compare
Mac and Windows test passing for the |
Closing in favor of #2811 |
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Supports numpy 2.0 now that onnxruntime supports it by removing our limit of <2.0 - Change usage of `float_` to `float64`. These are supported in both < and >= 2.0. However `float_` is only supported by < 2.0. In < 2.0 the _ types are shorthand for the 64bit wide datatypes. I verified this. This makes the changes cleaner than #2776. <img width="300" alt="Screenshot 2024-09-17 at 10 15 21 AM" src="https://github.com/user-attachments/assets/8e290733-419c-4d3c-9d71-dc76d01618d7"> - New functionality - None ## Test plan *How are these changes tested?* Existing tests - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?