Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#49) user story as a new rider i want to provide my personal information to create an account #50

Conversation

chriscoderdr
Copy link
Owner

Description

Please include a summary of the change and which issue is fixed. Include relevant context, motivation, and background.

Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code where necessary
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

…information to create an account.

- added shared library for login,register components
…information to create an account.

- fixes regarding shared library
- added input text  component to shared library
…information to create an account.

- moving components we made in driver app to the shared library
…information to create an account.

- fixes on shared components
…information to create an account.

- moving some logic from driver app to rider app (maybe we can share later)
- adding dependencies in rider app
…information to create an account.

- fixing imports
- adding some dependencies
- fixes
…information to create an account.

- implemented login/sign up form reusing components from driver app
…information to create an account.

- fixes regarding shared components
…information to create an account.

- after a lot of trial and error trying to use the shared library i changes to use library as file: because the workspace link was not working for some reason
- added watch command which listen to changes in src of the library, recompiles and reinstall modules in rider app (for now)
…information to create an account.

- fixing shared module types not exporting/module resolution of types not working
…information to create an account.

- login logic (changed a bit from the driver, we will update the driver app later)
…information to create an account.

- moving fetching logic to store, moving error logic to store
…information to create an account.

- adding patches to fix arning on country picker
- register logic
- adding in shared components a way to pass method to go to login
…information to create an account.

- adding login to user
…information to create an account.

- refactoring
- deleting no neded stuff from the driver
@chriscoderdr chriscoderdr self-assigned this Nov 6, 2024
@chriscoderdr chriscoderdr merged commit 638ffe5 into main Nov 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant