-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Story: As a new rider, I want to provide my personal information to create an account. #49
Comments
As we alreday made this components for driver's app I'll create a shared library |
encountered this problem while trying to create the shared package: facebook/react#24928 WIP |
…information to create an account. - added shared library for login,register components
…information to create an account. - fixes regarding facebook/react#24928
…information to create an account. - fixes regarding shared library - added input text component to shared library
…information to create an account. - moving components we made in driver app to the shared library
…information to create an account. - fixes on shared components
…information to create an account. - moving some logic from driver app to rider app (maybe we can share later) - adding dependencies in rider app
…information to create an account. - fixing imports - adding some dependencies - fixes
…information to create an account. - implemented login/sign up form reusing components from driver app
been trying to include the components, all are working except the ones that have native components included (mapbox, phone-input) |
…information to create an account. - fixes regarding shared components
So i spend the day trying the library to work as a workspace: it didn't (wrong relative link) I'm using as a file instead: but the problem is if I made a change it won't refresh yarn install --force kinda solves the problem but I don't want to reinstall the whole dependencies my solution will be yarn add morro-taxi-rn-components@file:packages/morro-taxi-rn-components yarn add morro-taxi-rn-components@file:./../../packages/morro-taxi-rn-components won't work because it's use the route of the main project in the workspace instead of the app I will make a watch in the library project that will rebuild and do yarn add in the projects |
…information to create an account. - after a lot of trial and error trying to use the shared library i changes to use library as file: because the workspace link was not working for some reason - added watch command which listen to changes in src of the library, recompiles and reinstall modules in rider app (for now)
…information to create an account. - fixing shared module types not exporting/module resolution of types not working
…information to create an account. - login logic (changed a bit from the driver, we will update the driver app later)
…information to create an account. - moving fetching logic to store, moving error logic to store
…information to create an account. - adding patches to fix arning on country picker - register logic - adding in shared components a way to pass method to go to login
…information to create an account. - adding login to user
…information to create an account. - refactoring - deleting no neded stuff from the driver
I ended up changing how auth works and letting redux do the work, will need to change this also on the driver, but this is for another time, will also need to refactor, just made it functional for now. |
…ormation to create an account (#50) * feat(#49): User Story: As a new rider, I want to provide my personal information to create an account. - added shared library for login,register components * feat(#49): User Story: As a new rider, I want to provide my personal information to create an account. - fixes regarding facebook/react#24928 * feat(#49): User Story: As a new rider, I want to provide my personal information to create an account. - fixes regarding shared library - added input text component to shared library * feat(#49): User Story: As a new rider, I want to provide my personal information to create an account. - moving components we made in driver app to the shared library * feat(#49): User Story: As a new rider, I want to provide my personal information to create an account. - fixes on shared components * feat(#49): User Story: As a new rider, I want to provide my personal information to create an account. - moving some logic from driver app to rider app (maybe we can share later) - adding dependencies in rider app * feat(#49): User Story: As a new rider, I want to provide my personal information to create an account. - fixing imports - adding some dependencies - fixes * feat(#49): User Story: As a new rider, I want to provide my personal information to create an account. - implemented login/sign up form reusing components from driver app * feat(#49): User Story: As a new rider, I want to provide my personal information to create an account. - fixes regarding shared components * feat(#49): User Story: As a new rider, I want to provide my personal information to create an account. - after a lot of trial and error trying to use the shared library i changes to use library as file: because the workspace link was not working for some reason - added watch command which listen to changes in src of the library, recompiles and reinstall modules in rider app (for now) * feat(#49): User Story: As a new rider, I want to provide my personal information to create an account. - fixing shared module types not exporting/module resolution of types not working * feat(#49): User Story: As a new rider, I want to provide my personal information to create an account. - login logic (changed a bit from the driver, we will update the driver app later) * feat(#49): User Story: As a new rider, I want to provide my personal information to create an account. - moving fetching logic to store, moving error logic to store * feat(#49): User Story: As a new rider, I want to provide my personal information to create an account. - adding patches to fix arning on country picker - register logic - adding in shared components a way to pass method to go to login * feat(#49): User Story: As a new rider, I want to provide my personal information to create an account. - adding login to user * feat(#49): User Story: As a new rider, I want to provide my personal information to create an account. - refactoring - deleting no neded stuff from the driver
…information to create an account. - added shared library for login,register components
…information to create an account. - fixes regarding facebook/react#24928
…information to create an account. - fixes regarding shared library - added input text component to shared library
…information to create an account. - moving components we made in driver app to the shared library
…information to create an account. - fixes on shared components
…information to create an account. - moving some logic from driver app to rider app (maybe we can share later) - adding dependencies in rider app
…information to create an account. - fixing imports - adding some dependencies - fixes
…information to create an account. - implemented login/sign up form reusing components from driver app
…information to create an account. - fixes regarding shared components
…information to create an account. - after a lot of trial and error trying to use the shared library i changes to use library as file: because the workspace link was not working for some reason - added watch command which listen to changes in src of the library, recompiles and reinstall modules in rider app (for now)
…information to create an account. - fixing shared module types not exporting/module resolution of types not working
…information to create an account. - login logic (changed a bit from the driver, we will update the driver app later)
…information to create an account. - moving fetching logic to store, moving error logic to store
…information to create an account. - adding patches to fix arning on country picker - register logic - adding in shared components a way to pass method to go to login
…information to create an account. - adding login to user
…information to create an account. - refactoring - deleting no neded stuff from the driver
…information to create an account. - added shared library for login,register components
…information to create an account. - fixes regarding facebook/react#24928
…information to create an account. - fixes regarding shared library - added input text component to shared library
…information to create an account. - moving components we made in driver app to the shared library
…information to create an account. - fixes on shared components
…information to create an account. - moving some logic from driver app to rider app (maybe we can share later) - adding dependencies in rider app
…information to create an account. - fixing imports - adding some dependencies - fixes
…information to create an account. - implemented login/sign up form reusing components from driver app
…information to create an account. - fixes regarding shared components
…information to create an account. - after a lot of trial and error trying to use the shared library i changes to use library as file: because the workspace link was not working for some reason - added watch command which listen to changes in src of the library, recompiles and reinstall modules in rider app (for now)
…information to create an account. - fixing shared module types not exporting/module resolution of types not working
…information to create an account. - login logic (changed a bit from the driver, we will update the driver app later)
…information to create an account. - moving fetching logic to store, moving error logic to store
…information to create an account. - adding patches to fix arning on country picker - register logic - adding in shared components a way to pass method to go to login
…information to create an account. - adding login to user
…information to create an account. - refactoring - deleting no neded stuff from the driver
No description provided.
The text was updated successfully, but these errors were encountered: