Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1TLB: fix support for configurable Sets/Ways #2621

Merged
merged 3 commits into from
Aug 28, 2020
Merged

Conversation

ingallsj
Copy link
Contributor

Related issue: follow-on after #2574

Type of change: feature enhancement

Impact: API addition (no impact on existing code)

Development Phase: implementation

Release Notes

  1. Restore the old field, nTLBEntries, by computing what it would be based on the new parameters. Otherwise, this was a backwards-incompatible change for downstream users that were relying on this.
  2. Propagate renaming nEntries to nWays in TLBConfig.
  3. Fix a bug where TLB's sectored_plru was too wide (nWays when it should be nWays/nSectors).
  4. Add a Seq variant for the access method in SetAssocLRU to support multiple simultaneous updates.

…ries -> nWays; OMCaches keep nTLBEntries for backwards compatibility
@ingallsj ingallsj changed the title Setassoc l1 tlb L1TLB: fix support for configurable Sets/Ways Aug 27, 2020
Copy link
Member

@richardxia richardxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! (Although I can't say that I am knowledgable about the hardware code to provide a technical review of that stuff, but the math works to me for the other stuff.)

src/main/scala/util/Replacement.scala Outdated Show resolved Hide resolved
@ingallsj ingallsj merged commit 2047410 into master Aug 28, 2020
@ingallsj ingallsj deleted the setassoc-L1-TLB branch August 28, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants