Changed the function called cover to mincover. Tightened the bound for the fragmenter by adding shrinktransfer. Added comment. #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcook
reviewed
Jul 24, 2020
hcook
reviewed
Jul 24, 2020
hcook
reviewed
Jul 24, 2020
jchang0
approved these changes
Jul 24, 2020
terpstra
approved these changes
Jul 27, 2020
hcook
approved these changes
Jul 27, 2020
For the record this an API modification. I doubt any users are calling it but we need to be intentional on these kinds of things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: other enhancement
Impact: API addition (no impact on existing code)
Development Phase: implementation
Release Notes
Changed the function called cover to mincover.
Tightened the bound for the fragmenter by adding shrinktransfer.
Added comment.
Changed setName to name in the v2 constructor.
This is part of adding emits parameters to RC.