Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TileLink Diplomacy parameters supportsProbe -> supports.probe #2567

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

ingallsj
Copy link
Contributor

Related issue: deprecated in #2505

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation

Release Notes
fix these Chisel compile deprecation warnings:

[warn] /rocket-chip/src/main/scala/tilelink/BankBinder.scala:27:30: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]       supportsProbe      = c.supportsProbe      intersect maxXfer,
[warn]                              ^
[warn] /rocket-chip/src/main/scala/tilelink/BankBinder.scala:28:30: method supportsArithmetic in class TLMasterParameters is deprecated: Use supports.arithmetic instead of supportsArithmetic
[warn]       supportsArithmetic = c.supportsArithmetic intersect maxXfer,
[warn]                              ^
[warn] /rocket-chip/src/main/scala/tilelink/BankBinder.scala:29:30: method supportsLogical in class TLMasterParameters is deprecated: Use supports.logical instead of supportsLogical
[warn]       supportsLogical    = c.supportsLogical    intersect maxXfer,
[warn]                              ^
[warn] /rocket-chip/src/main/scala/tilelink/BankBinder.scala:30:30: method supportsGet in class TLMasterParameters is deprecated: Use supports.get instead of supportsGet
[warn]       supportsGet        = c.supportsGet        intersect maxXfer,
[warn]                              ^
[warn] /rocket-chip/src/main/scala/tilelink/BankBinder.scala:31:30: method supportsPutFull in class TLMasterParameters is deprecated: Use supports.putFull instead of supportsPutFull
[warn]       supportsPutFull    = c.supportsPutFull    intersect maxXfer,
[warn]                              ^
[warn] /rocket-chip/src/main/scala/tilelink/BankBinder.scala:32:30: method supportsPutPartial in class TLMasterParameters is deprecated: Use supports.putPartial instead of supportsPutPartial
[warn]       supportsPutPartial = c.supportsPutPartial intersect maxXfer,
[warn]                              ^
[warn] /rocket-chip/src/main/scala/tilelink/BankBinder.scala:33:30: method supportsHint in class TLMasterParameters is deprecated: Use supports.hint instead of supportsHint
[warn]       supportsHint       = c.supportsHint       intersect maxXfer)})}
[warn]                              ^
[warn] /rocket-chip/src/main/scala/tilelink/Broadcast.scala:93:37: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]       val caches = clients.filter(_.supportsProbe).map(_.sourceId)
[warn]                                     ^
[warn] /rocket-chip/src/main/scala/tilelink/CacheCork.scala:35:39: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]         val caches = clients.filter(_.supportsProbe)
[warn]                                       ^
[warn] /rocket-chip/src/main/scala/tilelink/Filter.scala:20:20: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]         require (c.supportsProbe.contains(o.supportsProbe))
[warn]                    ^
[warn] /rocket-chip/src/main/scala/tilelink/Filter.scala:20:45: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]         require (c.supportsProbe.contains(o.supportsProbe))
[warn]                                             ^
[warn] /rocket-chip/src/main/scala/tilelink/Filter.scala:21:20: method supportsArithmetic in class TLMasterParameters is deprecated: Use supports.arithmetic instead of supportsArithmetic
[warn]         require (c.supportsArithmetic.contains(o.supportsArithmetic))
[warn]                    ^
[warn] /rocket-chip/src/main/scala/tilelink/Filter.scala:21:50: method supportsArithmetic in class TLMasterParameters is deprecated: Use supports.arithmetic instead of supportsArithmetic
[warn]         require (c.supportsArithmetic.contains(o.supportsArithmetic))
[warn]                                                  ^
[warn] /rocket-chip/src/main/scala/tilelink/Filter.scala:22:20: method supportsLogical in class TLMasterParameters is deprecated: Use supports.logical instead of supportsLogical
[warn]         require (c.supportsLogical.contains(o.supportsLogical))
[warn]                    ^
[warn] /rocket-chip/src/main/scala/tilelink/Filter.scala:22:47: method supportsLogical in class TLMasterParameters is deprecated: Use supports.logical instead of supportsLogical
[warn]         require (c.supportsLogical.contains(o.supportsLogical))
[warn]                                               ^
[warn] /rocket-chip/src/main/scala/tilelink/Filter.scala:23:20: method supportsGet in class TLMasterParameters is deprecated: Use supports.get instead of supportsGet
[warn]         require (c.supportsGet.contains(o.supportsGet))
[warn]                    ^
[warn] /rocket-chip/src/main/scala/tilelink/Filter.scala:23:43: method supportsGet in class TLMasterParameters is deprecated: Use supports.get instead of supportsGet
[warn]         require (c.supportsGet.contains(o.supportsGet))
[warn]                                           ^
[warn] /rocket-chip/src/main/scala/tilelink/Filter.scala:24:20: method supportsPutFull in class TLMasterParameters is deprecated: Use supports.putFull instead of supportsPutFull
[warn]         require (c.supportsPutFull.contains(o.supportsPutFull))
[warn]                    ^
[warn] /rocket-chip/src/main/scala/tilelink/Filter.scala:24:47: method supportsPutFull in class TLMasterParameters is deprecated: Use supports.putFull instead of supportsPutFull
[warn]         require (c.supportsPutFull.contains(o.supportsPutFull))
[warn]                                               ^
[warn] /rocket-chip/src/main/scala/tilelink/Filter.scala:25:20: method supportsPutPartial in class TLMasterParameters is deprecated: Use supports.putPartial instead of supportsPutPartial
[warn]         require (c.supportsPutPartial.contains(o.supportsPutPartial))
[warn]                    ^
[warn] /rocket-chip/src/main/scala/tilelink/Filter.scala:25:50: method supportsPutPartial in class TLMasterParameters is deprecated: Use supports.putPartial instead of supportsPutPartial
[warn]         require (c.supportsPutPartial.contains(o.supportsPutPartial))
[warn]                                                  ^
[warn] /rocket-chip/src/main/scala/tilelink/Filter.scala:26:20: method supportsHint in class TLMasterParameters is deprecated: Use supports.hint instead of supportsHint
[warn]         require (c.supportsHint.contains(o.supportsHint))
[warn]                    ^
[warn] /rocket-chip/src/main/scala/tilelink/Filter.scala:26:44: method supportsHint in class TLMasterParameters is deprecated: Use supports.hint instead of supportsHint
[warn]         require (c.supportsHint.contains(o.supportsHint))
[warn]                                            ^
[warn] /rocket-chip/src/main/scala/tilelink/Filter.scala:149:11: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]     if (c.supportsProbe) None else Some(c)
[warn]           ^
[warn] /rocket-chip/src/main/scala/tilelink/Filter.scala:153:11: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]     if (c.supportsProbe) Some(c) else None
[warn]           ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:862:12: method supportsPutFull in class TLMasterParameters is deprecated: Use supports.putFull instead of supportsPutFull
[warn]   require (supportsPutFull.contains(supportsPutPartial))
[warn]            ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:862:37: method supportsPutPartial in class TLMasterParameters is deprecated: Use supports.putPartial instead of supportsPutPartial
[warn]   require (supportsPutFull.contains(supportsPutPartial))
[warn]                                     ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:864:12: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]   require (supportsProbe.contains(supportsArithmetic))
[warn]            ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:864:35: method supportsArithmetic in class TLMasterParameters is deprecated: Use supports.arithmetic instead of supportsArithmetic
[warn]   require (supportsProbe.contains(supportsArithmetic))
[warn]                                   ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:865:12: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]   require (supportsProbe.contains(supportsLogical))
[warn]            ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:865:35: method supportsLogical in class TLMasterParameters is deprecated: Use supports.logical instead of supportsLogical
[warn]   require (supportsProbe.contains(supportsLogical))
[warn]                                   ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:866:12: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]   require (supportsProbe.contains(supportsGet))
[warn]            ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:866:35: method supportsGet in class TLMasterParameters is deprecated: Use supports.get instead of supportsGet
[warn]   require (supportsProbe.contains(supportsGet))
[warn]                                   ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:867:12: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]   require (supportsProbe.contains(supportsPutFull))
[warn]            ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:867:35: method supportsPutFull in class TLMasterParameters is deprecated: Use supports.putFull instead of supportsPutFull
[warn]   require (supportsProbe.contains(supportsPutFull))
[warn]                                   ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:868:12: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]   require (supportsProbe.contains(supportsPutPartial))
[warn]            ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:868:35: method supportsPutPartial in class TLMasterParameters is deprecated: Use supports.putPartial instead of supportsPutPartial
[warn]   require (supportsProbe.contains(supportsPutPartial))
[warn]                                   ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:869:12: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]   require (supportsProbe.contains(supportsHint))
[warn]            ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:869:35: method supportsHint in class TLMasterParameters is deprecated: Use supports.hint instead of supportsHint
[warn]   require (supportsProbe.contains(supportsHint))
[warn]                                   ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:874:5: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]     supportsProbe.max,
[warn]     ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:875:5: method supportsArithmetic in class TLMasterParameters is deprecated: Use supports.arithmetic instead of supportsArithmetic
[warn]     supportsArithmetic.max,
[warn]     ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:876:5: method supportsLogical in class TLMasterParameters is deprecated: Use supports.logical instead of supportsLogical
[warn]     supportsLogical.max,
[warn]     ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:877:5: method supportsGet in class TLMasterParameters is deprecated: Use supports.get instead of supportsGet
[warn]     supportsGet.max,
[warn]     ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:878:5: method supportsPutFull in class TLMasterParameters is deprecated: Use supports.putFull instead of supportsPutFull
[warn]     supportsPutFull.max,
[warn]     ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:879:5: method supportsPutPartial in class TLMasterParameters is deprecated: Use supports.putPartial instead of supportsPutPartial
[warn]     supportsPutPartial.max).max
[warn]     ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:1123:44: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]   val allSupportProbe      = masters.map(_.supportsProbe)     .reduce(_ intersect _)
[warn]                                            ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:1124:44: method supportsArithmetic in class TLMasterParameters is deprecated: Use supports.arithmetic instead of supportsArithmetic
[warn]   val allSupportArithmetic = masters.map(_.supportsArithmetic).reduce(_ intersect _)
[warn]                                            ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:1125:44: method supportsLogical in class TLMasterParameters is deprecated: Use supports.logical instead of supportsLogical
[warn]   val allSupportLogical    = masters.map(_.supportsLogical)   .reduce(_ intersect _)
[warn]                                            ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:1126:44: method supportsGet in class TLMasterParameters is deprecated: Use supports.get instead of supportsGet
[warn]   val allSupportGet        = masters.map(_.supportsGet)       .reduce(_ intersect _)
[warn]                                            ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:1127:44: method supportsPutFull in class TLMasterParameters is deprecated: Use supports.putFull instead of supportsPutFull
[warn]   val allSupportPutFull    = masters.map(_.supportsPutFull)   .reduce(_ intersect _)
[warn]                                            ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:1128:44: method supportsPutPartial in class TLMasterParameters is deprecated: Use supports.putPartial instead of supportsPutPartial
[warn]   val allSupportPutPartial = masters.map(_.supportsPutPartial).reduce(_ intersect _)
[warn]                                            ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:1129:44: method supportsHint in class TLMasterParameters is deprecated: Use supports.hint instead of supportsHint
[warn]   val allSupportHint       = masters.map(_.supportsHint)      .reduce(_ intersect _)
[warn]                                            ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:1132:45: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]   val anySupportProbe      = masters.map(!_.supportsProbe.none)     .reduce(_ || _)
[warn]                                             ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:1133:45: method supportsArithmetic in class TLMasterParameters is deprecated: Use supports.arithmetic instead of supportsArithmetic
[warn]   val anySupportArithmetic = masters.map(!_.supportsArithmetic.none).reduce(_ || _)
[warn]                                             ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:1134:45: method supportsLogical in class TLMasterParameters is deprecated: Use supports.logical instead of supportsLogical
[warn]   val anySupportLogical    = masters.map(!_.supportsLogical.none)   .reduce(_ || _)
[warn]                                             ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:1135:45: method supportsGet in class TLMasterParameters is deprecated: Use supports.get instead of supportsGet
[warn]   val anySupportGet        = masters.map(!_.supportsGet.none)       .reduce(_ || _)
[warn]                                             ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:1136:45: method supportsPutFull in class TLMasterParameters is deprecated: Use supports.putFull instead of supportsPutFull
[warn]   val anySupportPutFull    = masters.map(!_.supportsPutFull.none)   .reduce(_ || _)
[warn]                                             ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:1137:45: method supportsPutPartial in class TLMasterParameters is deprecated: Use supports.putPartial instead of supportsPutPartial
[warn]   val anySupportPutPartial = masters.map(!_.supportsPutPartial.none).reduce(_ || _)
[warn]                                             ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:1138:45: method supportsHint in class TLMasterParameters is deprecated: Use supports.hint instead of supportsHint
[warn]   val anySupportHint       = masters.map(!_.supportsHint.none)      .reduce(_ || _)
[warn]                                             ^
[warn] /rocket-chip/src/main/scala/tilelink/Parameters.scala:1508:46: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]     TLSourceIdMapEntry(c.sourceId, c.name, c.supportsProbe, c.requestFifo)
[warn]                                              ^
[warn] /rocket-chip/src/main/scala/tilelink/ToAXI4.scala:36:52: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]     TLToAXI4IdMapEntry(m.id, c.sourceId, c.name, c.supportsProbe, c.requestFifo)
[warn]                                                    ^
[warn] /rocket-chip/src/main/scala/tilelink/ToAXI4.scala:281:12: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]     if ( a.supportsProbe && !b.supportsProbe) return false
[warn]            ^
[warn] /rocket-chip/src/main/scala/tilelink/ToAXI4.scala:281:32: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]     if ( a.supportsProbe && !b.supportsProbe) return false
[warn]                                ^
[warn] /rocket-chip/src/main/scala/tilelink/ToAXI4.scala:282:12: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]     if (!a.supportsProbe &&  b.supportsProbe) return true
[warn]            ^
[warn] /rocket-chip/src/main/scala/tilelink/ToAXI4.scala:282:32: method supportsProbe in class TLMasterParameters is deprecated: Use supports.probe instead of supportsProbe
[warn]     if (!a.supportsProbe &&  b.supportsProbe) return true
[warn]                                ^

@ingallsj ingallsj merged commit cd4fa10 into master Jul 22, 2020
@ingallsj ingallsj deleted the diplomacy_tilelink_supports branch July 22, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants