subsystem: add an optional node to use for assigning hartids #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful when the hartid of a core cannot be known statically.
terpstra
force-pushed
the
optional-hartid-prefix
branch
from
9dbdccf
to
6a31846
Compare
ingallsj
approved these changes
May 2, 2020
hcook
reviewed
May 4, 2020
| @@ -80,14 +82,29 @@ class RocketSubsystem(implicit p: Parameters) extends BaseSubsystem | |||
| // add Mask ROM devices | |||
| val maskROMs = p(PeripheryMaskROMKey).map { MaskROM.attach(_, cbus) } | |||
|
|
|||
| val hartPrefixNode = if (p(HartPrefixKey)) { | |||
There was a problem hiding this comment.
If possible, I would put this in the trait HasTiles or HasRocketTiles, both of which actually currently get reused across multiple BaseSubsystem subclasses, unlike RocketSubsystem which is only used here and in soc-testsocket-sifive
There was a problem hiding this comment.
I would do that, but then this PR would break those other subclasses. Since the hartReg() part of this is needed to unblock the pipeline, I think I will do that refactor as a follow-up PR.
For whatever reason, this step is hanging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when the hartid of a core cannot be known statically.
Type of change: feature request
Impact: API addition (no impact on existing code)
Development Phase: implementation