Diplomatic tilelink "v1" parameter fixes #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcook
force-pushed
the
diplomatic-tilelink-parameter-fixes
branch
from
f29b0c9
to
30963e5
Compare
terpstra
approved these changes
Apr 22, 2020
rmac-sifive
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2320 introduced a bug in
TLSlaveParameters.v1copythat was then rolled out at large via #2353. The wrongnameval was used in the copy constructor. Outcome of the bug is that many TLSlaves have been reporting their name as"disconnected". However, in practice these names seem to only appear in e.g. diplomaticrequirefailures that attempt to use the name of the failing slave in their error message. I don't believe any verilog emission was actually affected by this bug.I fixed the bug in 8ab8246, but I think this bug could have been avoided by making
setNameanOptionso thatnameandsetNamehave different types. Handling it this way cleans up thesetNamecode; there is a fundamental difference between setting/not-setting the name and choosing to name something"". I make this further change in f29b0c9. Since the API is private I think this is still a free action, thought it might impact #2365.