Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chisel compile warning: TileLink Parameters v1 #2353

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Conversation

ingallsj
Copy link
Contributor

@ingallsj ingallsj commented Mar 22, 2020

Type of change: other enhancement (paying off technical debt)
Impact: (should be) no functional change
Development Phase: implementation

fix these Chisel compile warnings:

method apply in object TLClientParameters is deprecated: Use TLMasterParameters.v1 instead of TLClientParameters
method apply in object TLClientPortParameters is deprecated: Use TLMasterPortParameters.v1 instead of TLClientPortParameters
method apply in object TLManagerParameters is deprecated: Use TLSlaveParameters.v1 instead of TLManagerParameters
method apply in object TLManagerPortParameters is deprecated: Use TLSlavePortParameters.v1 instead of TLManagerPortParameters
method copy in class TLMasterParameters is deprecated: Use v1copy instead of copy
method copy in class TLMasterPortParameters is deprecated: Use v1copy instead of copy
method copy in class TLSlaveParameters is deprecated: Use v1copy instead of copy

@ingallsj ingallsj requested review from hcook and terpstra March 22, 2020 20:09
Copy link
Contributor

@terpstra terpstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@terpstra
Copy link
Contributor

We should really finish the job by adding the '.v2' constructors where managers->slaves and clients->masters. And then rename the TL node appropriately. (I'm not asking you to do this)

@ingallsj ingallsj closed this Mar 27, 2020
@ingallsj ingallsj deleted the warn-TLParamsV1 branch March 27, 2020 01:34
@ingallsj ingallsj restored the warn-TLParamsV1 branch March 27, 2020 01:37
@ingallsj ingallsj reopened this Mar 27, 2020
@ingallsj ingallsj merged commit 69df9c7 into master Mar 27, 2020
@ingallsj ingallsj deleted the warn-TLParamsV1 branch March 27, 2020 03:40
@ingallsj ingallsj restored the warn-TLParamsV1 branch March 27, 2020 03:40
@ingallsj ingallsj deleted the warn-TLParamsV1 branch March 27, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants