A Pair of Phase-Ordering Fixes

[davidbiancolin]

While bumping Rocket Chip in Chipyard i ran into a couple of order issues with the initial Stage / Phase implementation. There many ways they can be fixed, but this is what i did:

1. The dependency manager can schedule TransformAnnotations behind chisel's AddImplicitOutputFile phase, which leads the down stream phases to use the instance of the annotation provided by AddImplicitOutputFile and not TransformAnnotations. I added a dependency between the two phases to resolve this.

2. The dependency manager can schedule AddDefaultTestSuites ahead of GenerateFirrtlAnnos, which leads to RocketTestSuiteAnnotations being serialized when they cannot be. While there are myriad ways to fix this i've simply marked them as unserializable.

Type of change: bug report

Impact: no functional change

Development Phase: implementation

Release Notes

• [stage] Fix a bug where unserializable RocketTestSuiteAnnotations were being serialized
• [stage] Fix a bug where the desired output file name was being superseded by another phase

[debs-sifive]

Looks good. Thanks for catching/fixing!

[davidbiancolin]

No problem. :)