BundleMap: improved API for user bits #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackkoenig In case you were planning on including these operators in chisel3; note the two improvements over the old version:
|
hcook
approved these changes
Mar 4, 2020
terpstra
force-pushed
the
improved-user-bits
branch
from
a184d71
to
213ac25
Compare
- Field unification can be customized and defaults to equality required - Bulk assignment of BundleMaps now uses defaults for missing fields - You must now define both a Field and Key class
terpstra
force-pushed
the
improved-user-bits
branch
from
4722b7f
to
b588c0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes
User bits API composability improved