Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug APB: Prevent aliasing on undefined addresses #2213

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

mwachs5
Copy link
Contributor

@mwachs5 mwachs5 commented Dec 2, 2019

Debug: Fill in undefined addresses in APB interface with TLError device.

Note: making this a follow-on to #2205 would allow this to have less hardware impact

Related issue:

Type of change: bug report

Impact: API modification

Development Phase: implementation

Release Notes

Resolve issue in which accesses to the APB Debug interface which targeted undefined addresses would alias to valid addresses. Instead, these accesses will now return an error.

Debug: Fill in holes in APB interface with TLError device
Copy link
Contributor

@ernie-sifive ernie-sifive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mwachs5 mwachs5 merged commit 9ad9332 into master Dec 2, 2019
@mwachs5 mwachs5 deleted the debug-apb-aliasing branch June 9, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants