[SVSim] Fixed non-firing AssertProperty in SVSim #4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
reviewed
May 23, 2024
jackkoenig
approved these changes
May 23, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2024
(cherry picked from commit d3ab477) # Conflicts: # src/test/scala/chiselTests/LTLSpec.scala # svsim/src/main/scala/verilator/Backend.scala
14 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2024
(cherry picked from commit d3ab477)
14 tasks
chiselbot
pushed a commit
that referenced
this pull request
May 23, 2024
chiselbot
pushed a commit
that referenced
this pull request
May 23, 2024
) * [SVSim] Fixed non-firing AssertProperty in SVSim (#4087) (cherry picked from commit d3ab477) # Conflicts: # src/test/scala/chiselTests/LTLSpec.scala # svsim/src/main/scala/verilator/Backend.scala * Resolve backport conflicts --------- Co-authored-by: Amelia Dobis <amelia.dobis@sifive.com> Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AssertProperty was failing to fire when used in simulation with verilator. This was due to a missing
--assertflag that the simulator (stupidly) requires to support assertions.Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
AssertPropertyfailing to fire in verilator simulation.Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.