Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove circt.Intrinsic annotation. #3945

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Remove circt.Intrinsic annotation. #3945

merged 1 commit into from
Mar 20, 2024

Conversation

dtzSiFive
Copy link
Member

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API deprecation

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

IntrinsicModules (intmodule's in FIRRTL) have replaced this entirely for some time now.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@dtzSiFive
Remove circt.Intrinsic annotation.
e4e4547 
IntrinsicModules (intmodule's in FIRRTL) have replaced this entirely
for some time now.
@dtzSiFive dtzSiFive added the Deprecation Deprecates an API, will be included in release notes label Mar 20, 2024
@dtzSiFive dtzSiFive mentioned this pull request Mar 20, 2024
Merged
@dtzSiFive dtzSiFive added this to the 7.0 milestone Mar 20, 2024
@dtzSiFive dtzSiFive enabled auto-merge (squash) March 20, 2024 19:45
@jackkoenig jackkoenig added API Modification and removed Deprecation Deprecates an API, will be included in release notes labels Mar 20, 2024
jackkoenig
jackkoenig approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a modification (since it is a removal), not a deprecation, but LGTM!

@dtzSiFive dtzSiFive merged commit 8c55c80 into chipsalliance:main Mar 20, 2024
19 checks passed
@dtzSiFive
Copy link
Member Author

This is a modification (since it is a removal), not a deprecation, but LGTM!

Yes. Thanks!

@dtzSiFive dtzSiFive deleted the feature/remove-circt-intrinsic-unused branch March 20, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianschuiki fabianschuiki fabianschuiki approved these changes

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
API Modification
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dtzSiFive @fabianschuiki @jackkoenig